Change in vdsm[master]: tests: modprobe validation handle failure
danken at redhat.com
danken at redhat.com
Thu Dec 3 10:07:44 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: tests: modprobe validation handle failure
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/49538/2/tests/modprobe.py
File tests/modprobe.py:
Line 65: if not os.path.exists('/sys/module/' + name):
Line 66: cmd_modprobe = [modprobe.cmd, name]
Line 67: rc, out, err = utils.execCmd(cmd_modprobe, sudo=True)
Line 68: if rc != 0:
Line 69: _fail_to_load_module(name, rc, err)
please include "out" as well, as Ido has suggested.
Line 70:
Line 71:
Line 72: def _fail_to_load_module(name, rc, err):
Line 73: raise SkipTest("This test requires %s module (failed to load module: "
--
To view, visit https://gerrit.ovirt.org/49538
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I276cc2cf2205323648364c62b9db8f40e14cc983
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list