Change in vdsm[master]: Adding python3 run for nosetests

nsoffer at redhat.com nsoffer at redhat.com
Thu Dec 3 08:52:01 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: Adding python3 run for nosetests
......................................................................


Patch Set 21: Code-Review+1

(1 comment)

Needs Pitor approval.

https://gerrit.ovirt.org/#/c/48051/21/tests/Makefile.am
File tests/Makefile.am:

Line 236: 	@echo '*** Running tests.  To skip this step place NOSE_EXCLUDE=.* ***'
Line 237: 	@echo '*** into your environment.  Do not submit untested code!    ***'
Line 238: 	$(top_srcdir)/tests/run_tests_local.sh crossImportsTests.py
Line 239: 	$(top_srcdir)/tests/run_tests_local.sh \
Line 240: 		$(test_modules_py2) $(device_modules)
Add PYTHON_EXE also for the python 2 call for symmetry and for not depending on system python.
Line 241: 	PYTHON_EXE=python3 $(top_srcdir)/tests/run_tests_local.sh \


-- 
To view, visit https://gerrit.ovirt.org/48051
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83355cce2af9125e6f017017905056956cd17081
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list