Change in vdsm[master]: net: publicise misc._visible_devs
ibarkan at redhat.com
ibarkan at redhat.com
Thu Dec 3 08:32:24 UTC 2015
Ido Barkan has uploaded a new change for review.
Change subject: net: publicise misc._visible_devs
......................................................................
net: publicise misc._visible_devs
It is used in many netinfo submodules
Change-Id: Ia836988f57aecb817f67655f2e33cd94dd3031d2
Signed-off-by: Ido Barkan <ibarkan at redhat.com>
---
M lib/vdsm/netinfo/bonding.py
M lib/vdsm/netinfo/bridges.py
M lib/vdsm/netinfo/misc.py
M lib/vdsm/netinfo/nics.py
M lib/vdsm/netinfo/vlans.py
5 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/49627/1
diff --git a/lib/vdsm/netinfo/bonding.py b/lib/vdsm/netinfo/bonding.py
index 98280b5..0181994 100644
--- a/lib/vdsm/netinfo/bonding.py
+++ b/lib/vdsm/netinfo/bonding.py
@@ -28,7 +28,7 @@
from ..utils import memoized
from ..ipwrapper import Link
-from .misc import _visible_devs
+from .misc import visible_devs
from . import nics
BONDING_ACTIVE_SLAVE = '/sys/class/net/%s/bonding/active_slave'
@@ -55,7 +55,7 @@
BONDING_MODES_NUMBER_TO_NAME = dict(
(v, k) for k, v in six.iteritems(BONDING_MODES_NAME_TO_NUMBER))
-bondings = partial(_visible_devs, Link.isBOND)
+bondings = partial(visible_devs, Link.isBOND)
def slaves(bond_name):
diff --git a/lib/vdsm/netinfo/bridges.py b/lib/vdsm/netinfo/bridges.py
index 487f2ee..b30b015 100644
--- a/lib/vdsm/netinfo/bridges.py
+++ b/lib/vdsm/netinfo/bridges.py
@@ -21,12 +21,12 @@
from glob import iglob
import os
-from .misc import _visible_devs
+from .misc import visible_devs
from ..ipwrapper import Link
BRIDGING_OPT = '/sys/class/net/%s/bridge/%s'
-bridges = partial(_visible_devs, Link.isBRIDGE)
+bridges = partial(visible_devs, Link.isBRIDGE)
def ports(bridge):
diff --git a/lib/vdsm/netinfo/misc.py b/lib/vdsm/netinfo/misc.py
index 9acffa6..ffee477 100644
--- a/lib/vdsm/netinfo/misc.py
+++ b/lib/vdsm/netinfo/misc.py
@@ -44,7 +44,7 @@
return ifaceCfg
-def _visible_devs(predicate):
+def visible_devs(predicate):
"""Returns a list of visible (vdsm manageable) links for which the
predicate is True"""
return [dev.name for dev in getLinks() if predicate(dev) and
diff --git a/lib/vdsm/netinfo/nics.py b/lib/vdsm/netinfo/nics.py
index b2fd6ad..53e9ae3 100644
--- a/lib/vdsm/netinfo/nics.py
+++ b/lib/vdsm/netinfo/nics.py
@@ -22,7 +22,7 @@
import logging
from ..ipwrapper import drv_name
-from .misc import _visible_devs
+from .misc import visible_devs
from ..ipwrapper import Link
OPERSTATE_UP = 'up'
@@ -30,7 +30,7 @@
OPERSTATE_DOWN = 'down'
-nics = partial(_visible_devs, Link.isNICLike)
+nics = partial(visible_devs, Link.isNICLike)
def operstate(nic_name):
diff --git a/lib/vdsm/netinfo/vlans.py b/lib/vdsm/netinfo/vlans.py
index 3b9142b..7a057e1 100644
--- a/lib/vdsm/netinfo/vlans.py
+++ b/lib/vdsm/netinfo/vlans.py
@@ -20,13 +20,13 @@
from functools import partial
from . import bonding
-from .misc import _visible_devs
+from .misc import visible_devs
from . import nics
from ..ipwrapper import getLink, Link
from ..netlink import link as nl_link
-vlans = partial(_visible_devs, Link.isVLAN)
+vlans = partial(visible_devs, Link.isVLAN)
def vlanDevsForIface(iface):
--
To view, visit https://gerrit.ovirt.org/49627
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia836988f57aecb817f67655f2e33cd94dd3031d2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
More information about the vdsm-patches
mailing list