Change in vdsm[master]: net: consolidate _BRIDGING_OPT_PATH and BRIDGING_OPT

ibarkan at redhat.com ibarkan at redhat.com
Thu Dec 3 08:32:22 UTC 2015


Ido Barkan has uploaded a new change for review.

Change subject: net: consolidate _BRIDGING_OPT_PATH and BRIDGING_OPT
......................................................................

net: consolidate _BRIDGING_OPT_PATH and BRIDGING_OPT

Those 2 constants were the same.  only netinfo.bridges.BRIDGING_OPT
was left.

Change-Id: I4f54fe8391c9368a658b21b2e40db7383998a246
Signed-off-by: Ido Barkan <ibarkan at redhat.com>
---
M lib/vdsm/network/configurators/iproute2.py
1 file changed, 2 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/49622/1

diff --git a/lib/vdsm/network/configurators/iproute2.py b/lib/vdsm/network/configurators/iproute2.py
index 2b4f610..74a0020 100644
--- a/lib/vdsm/network/configurators/iproute2.py
+++ b/lib/vdsm/network/configurators/iproute2.py
@@ -37,7 +37,6 @@
 from ..sourceroute import DynamicSourceRoute
 from ..utils import remove_custom_bond_option
 
-_BRIDGING_OPT_PATH = '/sys/class/net/%s/bridge/%s'
 _ETHTOOL_BINARY = CommandPath(
     'ethtool',
     '/usr/sbin/ethtool',  # F19+
@@ -302,8 +301,8 @@
 
     def _setBridgeOpts(self, bridge, options):
         for key, value in (opt.split('=') for opt in options.split(' ')):
-            with open(_BRIDGING_OPT_PATH % (bridge.name, key), 'w') as optFile:
-                optFile.write(value)
+            with open(bridges.BRIDGING_OPT % (bridge.name, key), 'w') as f:
+                f.write(value)
 
     def removeBridge(self, bridge):
         rc, _, err = execCmd([EXT_BRCTL, 'delbr', bridge.name])


-- 
To view, visit https://gerrit.ovirt.org/49622
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f54fe8391c9368a658b21b2e40db7383998a246
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>


More information about the vdsm-patches mailing list