Change in vdsm[master]: tests: modprobe validation handle failure
ibarkan at redhat.com
ibarkan at redhat.com
Thu Dec 3 06:26:08 UTC 2015
Ido Barkan has posted comments on this change.
Change subject: tests: modprobe validation handle failure
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/49538/1/tests/modprobe.py
File tests/modprobe.py:
Line 38: if not os.path.exists('/sys/module/dummy'):
Line 39: cmd_modprobe = [modprobe.cmd, "dummy"]
Line 40: rc, out, err = utils.execCmd(cmd_modprobe, sudo=True)
Line 41: if rc != 0:
Line 42: raise SkipTest("This test requires dummy module")
> please include rc and err in the skip message, so we have a clue what cause
even out.
SkipTest("This test requires dummy module rc=%s, out=%s, err=%" % (rc, out, err))
Line 43:
Line 44: return f(*args, **kwargs)
Line 45: return wrapper
Line 46:
--
To view, visit https://gerrit.ovirt.org/49538
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I276cc2cf2205323648364c62b9db8f40e14cc983
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list