Change in vdsm[master]: v2v: add try/except to get_external_vms

mzamazal at redhat.com mzamazal at redhat.com
Wed Dec 2 15:49:48 UTC 2015


Milan Zamazal has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/49507/2/vdsm/v2v.py
File vdsm/v2v.py:

Line 175:                               e.message, vm.XMLDesc(0))
Line 176:                 continue
Line 177:             try:
Line 178:                 _add_networks(root, params)
Line 179:             except libvirt.libvirtError as e:
Can this be raised here? It seems to me that _add_networks just processes parsed DOM data.
Line 180:                 logging.error('error reading network configuration: %s', e)
Line 181:                 continue
Line 182:             try:
Line 183:                 _add_disks(root, params)


Line 180:                 logging.error('error reading network configuration: %s', e)
Line 181:                 continue
Line 182:             try:
Line 183:                 _add_disks(root, params)
Line 184:             except libvirt.libvirtError as e:
The same.
Line 185:                 logging.error('error reading disks configuration: %s', e)
Line 186:                 continue
Line 187:             for disk in params['disks']:
Line 188:                 _add_disk_info(conn, disk)


-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list