Change in vdsm[master]: hsm: Prevent stop monitoring of a pool domain

nsoffer at redhat.com nsoffer at redhat.com
Wed Dec 2 14:32:40 UTC 2015


Nir Soffer has submitted this change and it was merged.

Change subject: hsm: Prevent stop monitoring of a pool domain
......................................................................


hsm: Prevent stop monitoring of a pool domain

When hosted engine agent is entering local maintenance, it must stop
monitoring the hosted engine domain. This is racy because the domain may
be in the middle of an import operation.

To avoid this race, stopMonitoringDomain will fail now with new
StorageDomainIsMemberOfPool exception, so hosted engine agent can stop
monitoring safely.

This failure is also important even without this race; if a domain is
owned by the pool, nobody should be able to stop monitoring it. The only
way to stop monitoring a pool domain is disconnecting from the pool.

Change-Id: I99555b230dfdab41384af0461e4b30c590b669b9
Bug-Url: https://bugzilla.redhat.com/1282187
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/49387
Reviewed-by: Adam Litke <alitke at redhat.com>
Reviewed-by: Freddy Rolland <frolland at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/storage/hsm.py
M vdsm/storage/storage_exception.py
2 files changed, 16 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Verified
  Adam Litke: Looks good to me, approved
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Freddy Rolland: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/49387
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I99555b230dfdab41384af0461e4b30c590b669b9
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list