Change in vdsm[master]: monitor: Do not release host id during shutdown

nsoffer at redhat.com nsoffer at redhat.com
Wed Dec 2 14:31:59 UTC 2015


Nir Soffer has submitted this change and it was merged.

Change subject: monitor: Do not release host id during shutdown
......................................................................


monitor: Do not release host id during shutdown

When shutting down, all domain monitors are stopped and release acquired
host ids. This will cause sanlock to terminate processes holding a
resource on these domains, such as the qemu process for the hosted
engine vm.

This behavior was fine when the only resource held is the spm resource,
but now we must support the hosted engine vm, that must not be killed
when vdsm terminates. In the future we may like to use sanlock resources
for other vms as well.

Now we detect when a monitor is stopped during a vdsm shutdown, and do
not release the host id.

This change will effect users trying upgrade vdsm without putting a host
to maintenance before the upgrade. This was never supported but users
could get away with this by stopping vdsm. Now sanlock will refuse to
stop after vdsm is stopped, and killing sanlock will cause the watchdog
to reboot the machine.

Change-Id: Ib14fa48abf9c98fdce268c4675d71aab05c92b10
Bug-Url: https://bugzilla.redhat.com/1269768
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/49386
Reviewed-by: Sandro Bonazzola <sbonazzo at redhat.com>
Reviewed-by: Martin Sivák <msivak at redhat.com>
Reviewed-by: Adam Litke <alitke at redhat.com>
Reviewed-by: Freddy Rolland <frolland at redhat.com>
Tested-by: Roy Golan <rgolan at redhat.com>
Continuous-Integration: Jenkins CI
---
M vdsm/storage/hsm.py
M vdsm/storage/monitor.py
2 files changed, 20 insertions(+), 10 deletions(-)

Approvals:
  Nir Soffer: Verified
  Adam Litke: Looks good to me, approved
  Sandro Bonazzola: Looks good to me, but someone else must approve
  Martin Sivák: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Roy Golan: Verified
  Freddy Rolland: Looks good to me, but someone else must approve

Objections:
  Dan Kenigsberg: I would prefer that you didn't submit this



-- 
To view, visit https://gerrit.ovirt.org/49386
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib14fa48abf9c98fdce268c4675d71aab05c92b10
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list