Change in vdsm[ovirt-3.5]: ifcfg: remove files properly on the node

sshnaidm at redhat.com sshnaidm at redhat.com
Wed Dec 2 14:10:00 UTC 2015


Sagi Shnaidman has uploaded a new change for review.

Change subject: ifcfg: remove files properly on the node
......................................................................

ifcfg: remove files properly on the node

Since change-id I02ae28c345 we are always persisting ifcfg files on the
node. This means that we should unpersist them on removal.

Change-Id: I2ab83b3fad7679f8f3f459b682860a95e08d6b1e
Bug-Url: https://bugzilla.redhat.com/1283628
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/48841
Reviewed-by: Ido Barkan <ibarkan at redhat.com>
Reviewed-by: Fabian Deutsch <fabiand at redhat.com>
Tested-by: Sagi Shnaidman <sshnaidm at redhat.com>
Reviewed-by: Sagi Shnaidman <sshnaidm at redhat.com>
(cherry picked from commit 1ae349016221c52e1a80971aac2e5080ad33fd11)
Reviewed-on: https://gerrit.ovirt.org/49373
Continuous-Integration: Jenkins CI
(cherry picked from commit 4f14161196e29ca0d6076853cde47e2b63f744f6)
---
M vdsm/network/configurators/ifcfg.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/49575/1

diff --git a/vdsm/network/configurators/ifcfg.py b/vdsm/network/configurators/ifcfg.py
index e576dc0..b416f50 100644
--- a/vdsm/network/configurators/ifcfg.py
+++ b/vdsm/network/configurators/ifcfg.py
@@ -373,7 +373,7 @@
         logging.info("Rolling back configuration (restoring atomic backup)")
         for confFilePath, content in self._backups.iteritems():
             if content is None:
-                utils.rmFile(confFilePath)
+                self._removeFile(confFilePath)
                 logging.debug('Removing empty configuration backup %s',
                               confFilePath)
             else:


-- 
To view, visit https://gerrit.ovirt.org/49575
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ab83b3fad7679f8f3f459b682860a95e08d6b1e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Sagi Shnaidman <sshnaidm at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list