Change in vdsm[master]: guestagent: Rename connect() to start()

danken at redhat.com danken at redhat.com
Wed Dec 2 13:22:55 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: guestagent: Rename connect() to start()
......................................................................


guestagent: Rename connect() to start()

GuestAgent was started by invoking connect() and stopped by invoking
stop().  We can rename stop() to disconnect(), but it seems that it is
more clear to rename connect() to start(). This conforms with other
subsystems implementing this interface.

Change-Id: I649075cf67cb0db4e1aede14586d0b26f2bf59b4
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/49342
Reviewed-by: Vinzenz Feenstra <vfeenstr at redhat.com>
Reviewed-by: Milan Zamazal <mzamazal at redhat.com>
Reviewed-by: Francesco Romani <fromani at redhat.com>
Continuous-Integration: Jenkins CI
---
M vdsm/virt/guestagent.py
M vdsm/virt/vm.py
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Vinzenz Feenstra: Looks good to me, but someone else must approve
  Francesco Romani: Looks good to me, approved
  Milan Zamazal: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/49342
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I649075cf67cb0db4e1aede14586d0b26f2bf59b4
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list