Change in vdsm[master]: hsm: Prevent stop monitoring of a pool domain

ybronhei at redhat.com ybronhei at redhat.com
Wed Dec 2 11:49:58 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: hsm: Prevent stop monitoring of a pool domain
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/49387/5/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 3658:     def startMonitoringDomain(self, sdUUID, hostID, options=None):
Line 3659:         with rmanager.acquireResource(STORAGE, HSM_DOM_MON_LOCK,
Line 3660:                                       rm.LockType.exclusive):
Line 3661:             # Note: We cannot raise here StorageDomainIsMemberOfPool, as it
Line 3662:             # will break old hosted engine agent.
I would explain more why it can break HE agent .. for me the comment doesn't say much
Line 3663:             self.domainMonitor.startMonitoring(sdUUID, int(hostID), False)
Line 3664: 
Line 3665:     @deprecated
Line 3666:     @public


-- 
To view, visit https://gerrit.ovirt.org/49387
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99555b230dfdab41384af0461e4b30c590b669b9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list