Change in vdsm[master]: net: Mapping bonding option value names to numerics

edwardh at redhat.com edwardh at redhat.com
Wed Dec 2 09:57:07 UTC 2015


Edward Haas has posted comments on this change.

Change subject: net: Mapping bonding option value names to numerics
......................................................................


Patch Set 10:

(5 comments)

https://gerrit.ovirt.org/#/c/49390/10/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 242: e.errno == errno.EINVAL or e.errno == errno.EPER
> this can be more elegantly written as:
Done


Line 505: opt_num_val
> replace this with return
I prefer a single exit point when possible.


https://gerrit.ovirt.org/#/c/49390/10/lib/vdsm/tool/dump_bonding_opts.py
File lib/vdsm/tool/dump_bonding_opts.py:

Line 93: _bond_opts
> naming: context managers are usually named as nouns. like: bond_device. thi
Done


https://gerrit.ovirt.org/#/c/49390/10/tests/netinfoTests.py
File tests/netinfoTests.py:

Line 338: exist
> exists
Done


Line 348: exist
> exists
Done


-- 
To view, visit https://gerrit.ovirt.org/49390
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f4c16b1523822a2d53d4525841ff8741af6296c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list