Change in vdsm[master]: sp: Allow attaching of monitored domain

nsoffer at redhat.com nsoffer at redhat.com
Wed Dec 2 08:20:55 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: sp: Allow attaching of monitored domain
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/48217/4/vdsm/storage/monitor.py
File vdsm/storage/monitor.py:

Line 100: 
Line 101:         # TODO: Replace with explicit attach.
Line 102:         if monitor is not None:
Line 103:             if not poolDomain:
Line 104:                 # Expected when hosted engnine agent is restarting.
> /s/engnine/engine
Thanks, fixed in current version. The comment about hosted engine is important to understand the context. startMonitoringDomain is deprecated, so engine is unlikely to call it.
Line 105:                 self.log.debug("Monitor for %s is already running", sdUUID)
Line 106:                 return
Line 107: 
Line 108:             if monitor.poolDomain:


-- 
To view, visit https://gerrit.ovirt.org/48217
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list