Change in vdsm[master]: vm: snapshot - enabling memory snapshot for diskless VM

nsoffer at redhat.com nsoffer at redhat.com
Wed Dec 2 00:32:45 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: vm: snapshot - enabling memory snapshot for diskless VM
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/49535/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3137
Line 3138
Line 3139
Line 3140
Line 3141
> Previewing a snapshot without disks can be previewed. Though it's probably 
Until now, memory snapshot without disk did nothing. This looks like a bug, but I don't think we should change it.

The only change needed is supporting memory snapshot with cinder disk. Do we have an easy way to tell that we have a cinder disk here? We can use the frozen boolean, but it is too sneaky.

Lets think about a better way to do this. There is no rush, cinder is a new feature, and I don't see any problem if will not support memory snapshot in the current build.


-- 
To view, visit https://gerrit.ovirt.org/49535
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list