Change in vdsm[master]: monitor: Do not release host id during shutdown

nsoffer at redhat.com nsoffer at redhat.com
Tue Dec 1 17:49:16 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: monitor: Do not release host id during shutdown
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/49386/2//COMMIT_MSG
Commit Message:

Line 19: Now we detect when a monitor is stopped during a vdsm shutdown, and do
Line 20: not release the host id.
Line 21: 
Line 22: This change will effect users trying upgrade vdsm without putting a host
Line 23: to maintenance before the upgrade. This was never supported but users
> It may cause a reboot - sanlock refuse to stop because there are active
And it also possible today:
- You stop vdsm, but it get stuck during shutdown, and systemd kills it after 10 seconds, before it released the spm resource or all the lockspaces.
- You kill vdsm to upgrade it
Line 24: could get away with this by stopping vdsm. Now sanlock will refuse to
Line 25: stop after vdsm is stopped, and killing sanlock will cause the watchdog
Line 26: to reboot the machine.
Line 27: 


-- 
To view, visit https://gerrit.ovirt.org/49386
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib14fa48abf9c98fdce268c4675d71aab05c92b10
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list