Change in vdsm[master]: lib: daemon: autodetect online cpus for affinity

fromani at redhat.com fromani at redhat.com
Tue Dec 1 16:28:08 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: lib: daemon: autodetect online cpus for affinity
......................................................................


Patch Set 7:

(6 comments)

https://gerrit.ovirt.org/#/c/49402/7//COMMIT_MSG
Commit Message:

Line 14: setup
> setups
thanks, fixed.


Line 23: the
> that
thanks, fixed.


Line 32: little
> small
thanks, fixed.


https://gerrit.ovirt.org/#/c/49402/7/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 215: cpus
> cores?
Done


Line 212:             'This options selects the CPU cores on which VDSM is allowed '
Line 213:             'to run. '
Line 214:             'Use the empty value to disable the affinity, allowing VDSM '
Line 215:             'to run on all the online cpus. '
Line 216:             'The default is "auto", meaning VDSM will autoselect one '
> Please use Vdsm
Done
Line 217:             'online core randomly and will be pinned on it.'
Line 218:             'Valid examples: "1", "0,1", "0,2,3", "auto"'),
Line 219: 
Line 220:         ('ssl_implementation', '@SSL_IMPLEMENTATION@',


Line 213:             'to run. '
Line 214:             'Use the empty value to disable the affinity, allowing VDSM '
Line 215:             'to run on all the online cpus. '
Line 216:             'The default is "auto", meaning VDSM will autoselect one '
Line 217:             'online core randomly and will be pinned on it.'
> randomly? I think we need a clear predictable logic.
Your wording is better, thanks.
Yep, already implemented.
Line 218:             'Valid examples: "1", "0,1", "0,2,3", "auto"'),
Line 219: 
Line 220:         ('ssl_implementation', '@SSL_IMPLEMENTATION@',
Line 221:             'Specifies which ssl implementation should be used. '


-- 
To view, visit https://gerrit.ovirt.org/49402
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba834f67a43ce766308036cbd079107340ed69d8
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list