Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

mzamazal at redhat.com mzamazal at redhat.com
Tue Dec 1 15:53:50 UTC 2015


Milan Zamazal has posted comments on this change.

Change subject: v2v: externalVMList Xen+Kvm support
......................................................................


Patch Set 13: Code-Review+1

(4 comments)

Please fix the typos, otherwise fine for me.

https://gerrit.ovirt.org/#/c/48672/13//COMMIT_MSG
Commit Message:

Line 11: We want to use one verb to probe VMs information from Xen, KVM and
Line 12: vCenter, as well as old libvirt versions.
Line 13: Tested with RHEL 5.x and above.
Line 14: 
Line 15: Currently we externalVMList tested only with vCenter:
... we tested externalVMList ...
Line 16: vpx://...
Line 17: 
Line 18: Adding support for Kvm via libvirt:
Line 19: qemu+tcp://user@host/system


https://gerrit.ovirt.org/#/c/48672/13/tests/v2vTests.py
File tests/v2vTests.py:

Line 117:     def listAllDomains(self):
Line 118:         return [vm for vm in self._vms]
Line 119: 
Line 120:     def listDefinedDomains(self):
Line 121:         # listDefinedDomains return only inactive domains
... returns ...
Line 122:         return [vm.name for vm in self._vms if not vm.isActive]
Line 123: 
Line 124:     def listDomainsID(self):
Line 125:         # listDomainsID return only active domains


Line 121:         # listDefinedDomains return only inactive domains
Line 122:         return [vm.name for vm in self._vms if not vm.isActive]
Line 123: 
Line 124:     def listDomainsID(self):
Line 125:         # listDomainsID return only active domains
... returns ...
Line 126:         return [vm.id for vm in self._vms if vm.isActive]
Line 127: 
Line 128:     def lookupByName(self, name):
Line 129:         for vm in self._vms:


https://gerrit.ovirt.org/#/c/48672/13/vdsm/v2v.py
File vdsm/v2v.py:

Line 641:     try:
Line 642:         for vm in conn.listAllDomains():
Line 643:             yield vm
Line 644:     except libvirt.libvirtError as e:
Line 645:         # TODO: use new API: listAllDomain() when supported in Xen
... listAllDomains() ...
Line 646:         #       under RHEL 5.x
Line 647:         if e.get_error_code() != libvirt.VIR_ERR_NO_SUPPORT:
Line 648:             raise
Line 649:         seen = set()


-- 
To view, visit https://gerrit.ovirt.org/48672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7d7e211a9343a528f260da2686b34cea00c53a4
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list