Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

mzamazal at redhat.com mzamazal at redhat.com
Tue Dec 1 11:29:34 UTC 2015


Milan Zamazal has posted comments on this change.

Change subject: v2v: externalVMList Xen+Kvm support
......................................................................


Patch Set 12:

(2 comments)

https://gerrit.ovirt.org/#/c/48672/12/vdsm/v2v.py
File vdsm/v2v.py:

Line 647:         if e.get_error_code() != libvirt.VIR_ERR_NO_SUPPORT:
Line 648:             raise
Line 649:         seen = set()
Line 650:         for name in conn.listDefinedDomains():
Line 651:             vm = conn.lookupByName(name)
Shouldn't vmid be added to `seen'?
Line 652:             yield vm
Line 653:         for vmid in conn.listDomainsID():
Line 654:             if vmid in seen:
Line 655:                 continue


Line 653:         for vmid in conn.listDomainsID():
Line 654:             if vmid in seen:
Line 655:                 continue
Line 656:             vm = conn.lookupByID(vmid)
Line 657:             seen.add(vmid)
And is this one needed (duplicates in listDomainsID?)?
Line 658:             yield vm
Line 659: 
Line 660: 
Line 661: def _add_vm(conn, vms, vm):


-- 
To view, visit https://gerrit.ovirt.org/48672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7d7e211a9343a528f260da2686b34cea00c53a4
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list