Change in vdsm[master]: v2v: support for importing Xen VMs via libvirt on RHEL hosts

nsoffer at redhat.com nsoffer at redhat.com
Tue Dec 1 10:20:38 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/49505/1/vdsm/v2v.py
File vdsm/v2v.py:

Line 437:         if self._status != STATUS.ABORTED:
Line 438:             self._status = STATUS.DONE
Line 439:             logging.info('Job %r finished import successfully', self._id)
Line 440: 
Line 441:     def _init_ssh_agent(self):
Why do we need this? Is it needed for importing external vm and importing ova?

If this is need only for importing from xen, it should not be in this class. This class is becoming too big and maintainable.

Please break it to small classes doing one thing each before you add new features.
Line 442:         proc = execCmd([_SSH_AGENT.cmd], sync=False,
Line 443:                        deathSignal=signal.SIGTERM, nice=NICENESS.HIGH,
Line 444:                        ioclass=IOCLASS.IDLE)
Line 445:         proc.blocking = True


-- 
To view, visit https://gerrit.ovirt.org/49505
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If544c0247003b6bc7189f72130553b9402dc915d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list