Change in vdsm[ovirt-3.6]: hooks: hostusb: make sudoers rule more specific

ykaplan at redhat.com ykaplan at redhat.com
Tue Dec 1 10:15:34 UTC 2015


Hello Piotr Kliczewski, Yaniv Bronhaim,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/49509

to review the following change.

Change subject: hooks: hostusb: make sudoers rule more specific
......................................................................

hooks: hostusb: make sudoers rule more specific

Change-Id: Iaccc4fffd8ab055a0cd773df68b0431537901021
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1234304
Signed-off-by: Yeela Kaplan <ykaplan at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/48963
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
---
M vdsm_hooks/hostusb/sudoers.vdsm_hook_hostusb
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/49509/1

diff --git a/vdsm_hooks/hostusb/sudoers.vdsm_hook_hostusb b/vdsm_hooks/hostusb/sudoers.vdsm_hook_hostusb
index cba601d..51ea707 100644
--- a/vdsm_hooks/hostusb/sudoers.vdsm_hook_hostusb
+++ b/vdsm_hooks/hostusb/sudoers.vdsm_hook_hostusb
@@ -1 +1,3 @@
-vdsm  ALL=(ALL) NOPASSWD: /bin/chown
+Runas_Alias    OP = root, vdsm
+
+vdsm  ALL=(OP) NOPASSWD: /bin/chown /dev/bus/usb/*/*


-- 
To view, visit https://gerrit.ovirt.org/49509
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaccc4fffd8ab055a0cd773df68b0431537901021
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list