Change in vdsm[master]: PoC: enforcement of contract for notifications

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Tue Dec 1 09:58:33 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: PoC: enforcement of contract for notifications
......................................................................


Patch Set 1:

(4 comments)

https://gerrit.ovirt.org/#/c/49442/1/lib/api/notify-schema.yaml
File lib/api/notify-schema.yaml:

Line 37: 			type: string
Line 38: 	1.4:
Line 39: 		param:
Line 40: 			name: vm-id
Line 41: 			operation: removed
> we should have the ability to specify the complete deprecation of an event.
Agree, will update


https://gerrit.ovirt.org/#/c/49442/1/lib/api/notifyapi.py
File lib/api/notifyapi.py:

Line 1: 2014
> 2015
Done


https://gerrit.ovirt.org/#/c/49442/1/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:

Line 67:     DESTINATION = "destination"
Line 68:     ACCEPT_VERSION = "accept-version"
Line 69:     REPLY_TO = "reply-to"
Line 70:     HEARTEBEAT = "heart-beat"
Line 71:     CLIENT_VERSION = "client-version"
> make sure stomp is happy with adding this header
There is good number of examples in the spec where there are custom headers.
Line 72: 
Line 73: 
Line 74: COMMANDS = tuple([command for command in dir(Command)
Line 75:                   if not command.startswith('_')])


https://gerrit.ovirt.org/#/c/49442/1/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:

Line 127: default-version"
> I suggest to call it "3.6" so it fits the versioning scheme better.
Done


-- 
To view, visit https://gerrit.ovirt.org/49442
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c21a904b6dfa6c818ec7cd438f2520bf1f22fc8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list