Change in vdsm[master]: net: split netinfo module

ibarkan at redhat.com ibarkan at redhat.com
Tue Dec 1 09:42:12 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: net: split netinfo module
......................................................................


Patch Set 11:

(6 comments)

https://gerrit.ovirt.org/#/c/49198/11//COMMIT_MSG
Commit Message:

Line 10: fem
> few
Done


Line 12: easiyer
> easier
Done


https://gerrit.ovirt.org/#/c/49198/11/lib/vdsm/kernelconfig.py
File lib/vdsm/kernelconfig.py:

Line 25: bonding, bridges, addresses, mtus
> Every module import should be on its own line.
Done


https://gerrit.ovirt.org/#/c/49198/11/lib/vdsm/netinfo/Makefile.am
File lib/vdsm/netinfo/Makefile.am:

Line 2: Hat
> Red Hat
Done


https://gerrit.ovirt.org/#/c/49198/11/lib/vdsm/netinfo/__init__.py
File lib/vdsm/netinfo/__init__.py:

Line 19: from __future__ import absolute_import
> In the case we needed to add a comment before imports, I would prefer to ha
Done


Line 23: import errno
> Are you keeping the ordering the same as in netinfo.py so this file matched
Let it be... I don't really mind.


-- 
To view, visit https://gerrit.ovirt.org/49198
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I297b55f68f69c4ba0f1c854bcadddc087a2e9089
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list