Change in vdsm[master]: netinfo: assess DHCP on devices from cmdlines of dhclients

osvoboda at redhat.com osvoboda at redhat.com
Tue Dec 1 02:09:55 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: netinfo: assess DHCP on devices from cmdlines of dhclients
......................................................................


Patch Set 9:

(2 comments)

https://gerrit.ovirt.org/#/c/49097/9/lib/vdsm/dhcpinfo.py
File lib/vdsm/dhcpinfo.py:

Line 50: # No such file or directory (the process already exited)
> Noted.
Done


Line 57: argv[0].endswith('dhclient')
> Right. I was confused at first and wanted to hunt for differently named pro
Done


-- 
To view, visit https://gerrit.ovirt.org/49097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I160a0e2d4c734de94b0995e7433216baa88972ab
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list