Change in vdsm[master]: net: init: wait for ipv4 with monitoring

osvoboda at redhat.com osvoboda at redhat.com
Tue Dec 1 01:35:39 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: net: init: wait for ipv4 with monitoring
......................................................................


Patch Set 8: Code-Review+1

Nice reimplementation.

One question though: Ido will be moving more networking code to lib/vdsm soon. Are you planning to reuse some facilities (such as the constant '# Generated by VDSM version' in ifcfg.ConfigWriter or hopefully some functions) from the library then?

netinto.NET_CONF_DIR could be used right away instead of NETWORK_SCRIPTS but I don't mind if this happens later and it is a "constant" constant anyway.

-- 
To view, visit https://gerrit.ovirt.org/46148
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa9d53f8f436b5c5f11643ae03bdd768d555b83d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list