Change in vdsm[master]: ssl: configurable implementation
piotr.kliczewski at gmail.com
piotr.kliczewski at gmail.com
Mon Aug 31 15:36:55 UTC 2015
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: configurable implementation
......................................................................
Patch Set 5:
(5 comments)
https://gerrit.ovirt.org/#/c/44494/5/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 58: from cpopen import CPopen
Line 59: from . import cmdutils
Line 60: from . import constants
Line 61: try:
Line 62: from M2Crypto import SSL
> this logic can be hidden in sslcompat
Done
Line 63: _m2cEnabled = True
Line 64: except ImportError:
Line 65: import ssl
Line 66: _m2cEnabled = False
Line 1255: return count * size
Line 1256:
Line 1257:
Line 1258: def create_connected_socket(host, port, sslctx=None, timeout=None):
Line 1259: sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
> sock is not always used. can you assign it only when it is?
Done
Line 1260: if sslctx:
Line 1261: if _m2cEnabled:
Line 1262: sock = SSL.Connection(sslctx.context)
Line 1263: else:
https://gerrit.ovirt.org/#/c/44494/5/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 27: from . import JsonRpcClient, JsonRpcServer
Line 28: from . import stomp
Line 29: from .betterAsyncore import Dispatcher, Reactor
Line 30:
Line 31:
> unrelated newline
Done
Line 32: _STATE_LEN = "Waiting for message length"
Line 33: _STATE_MSG = "Waiting for message"
Line 34:
Line 35:
https://gerrit.ovirt.org/#/c/44494/5/tests/crossImportsTests.py.in
File tests/crossImportsTests.py.in:
Line 50: mods = get_mods(src_dir)
Line 51: else:
Line 52: mods = get_mods(os.path.join(get_python_lib(), pkg_name))
Line 53:
Line 54: # ignore M2Crypto
> # skip the test for m2cutils as we cannot even import it on systems with no
Done
Line 55: mods.remove('m2cutils')
Line 56:
https://gerrit.ovirt.org/#/c/44494/5/tests/integration/m2chelper.py
File tests/integration/m2chelper.py:
Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: import os
> unrelated newline removal
Done
Line 21: import SimpleXMLRPCServer
Line 22: import threading
Line 23: from M2Crypto import SSL
Line 24: from vdsm.m2cutils import SSLContext, SSLServerSocket
--
To view, visit https://gerrit.ovirt.org/44494
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6501981bbd5276c49731b0d9eba4794286b0f823
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list