Change in vdsm[master]: hsm: Support checkStatus param in getDeviceList

nsoffer at redhat.com nsoffer at redhat.com
Mon Aug 31 11:25:46 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: hsm: Support checkStatus param in getDeviceList
......................................................................


Patch Set 6:

(1 comment)

Looks good, but the commit is missing the big picture.

https://gerrit.ovirt.org/#/c/45093/6//COMMIT_MSG
Commit Message:

Line 22: sys     0m0.028s
Line 23: 
Line 24: real    0m57.769s
Line 25: user    0m0.265s
Line 26: sys     0m0.024s
This does not explain the flow, and the reader may think we are checking any more the device status because it is too slow, while we do check the status.

The motivation for this patch is avoiding paying for the expensive test when we don't have to.

The flow before this patch was:

- system get device list, perform expensive status check for each device, possibly times out
- user select couple of devices (typically one)
- system warn user about used devices

The flow with this patch is:

- system get device list, skipping status check
- user select couple of devices (typically one)
- system perform status check for select devices
- system warn user about used devices
Line 27: 
Line 28: Examples:
Line 29:     getDeviceList
Line 30:         return all devices


-- 
To view, visit https://gerrit.ovirt.org/45093
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic28954708f2fd7c7b721aa7f9a0fb6e1a6019597
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list