Change in vdsm[master]: network: add ifcfg write hook

danken at redhat.com danken at redhat.com
Mon Aug 31 09:55:37 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: network: add ifcfg write hook
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/44552/4/vdsm/network/configurators/ifcfg.py
File vdsm/network/configurators/ifcfg.py:

Line 546: 
Line 547:         hook_dict = _build_ifcfg_write_hook_dict(name,
Line 548:                                                  netinfo.NET_CONF_PREF + name,
Line 549:                                                  cfg)
Line 550:         hooks.before_ifcfg_write(hook_dict)
this returns the modified cfg content. we should take it here, and pass it to writeConfFile().
Line 551:         self.writeConfFile(netinfo.NET_CONF_PREF + name, cfg)
Line 552:         hooks.after_ifcfg_write(hook_dict)
Line 553: 
Line 554:     def addBridge(self, bridge, **opts):


Line 548:                                                  netinfo.NET_CONF_PREF + name,
Line 549:                                                  cfg)
Line 550:         hooks.before_ifcfg_write(hook_dict)
Line 551:         self.writeConfFile(netinfo.NET_CONF_PREF + name, cfg)
Line 552:         hooks.after_ifcfg_write(hook_dict)
I don't see the motivation for this hookpoint - please drop it.
Line 553: 
Line 554:     def addBridge(self, bridge, **opts):
Line 555:         """ Create ifcfg-* file with proper fields for bridge """
Line 556:         conf = 'TYPE=Bridge\nDELAY=0\n'


-- 
To view, visit https://gerrit.ovirt.org/44552
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2206ccf97b210bd58f03777d4ccd016785b02939
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list