Change in vdsm[master]: vm: Libvirt quering after disk detach operation addition.

aaviram at redhat.com aaviram at redhat.com
Mon Aug 31 09:18:34 UTC 2015


Amit Aviram has posted comments on this change.

Change subject: vm: Libvirt quering after disk detach operation addition.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/45138/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: vm: Libvirt quering after disk detach operation addition.
Line 8: 
Line 9: As stated in libvirt documentary, after detaching a device using the API
Line 10: we need to verify that this device has actually been detached.
> We have event dispatching/listening code. Short version:
We will need to do that in another patch, as this change is needed asap and that implementation requires time.. let's start with inserting something that works, than make it prettier in a following patch.
Line 11: 
Line 12: Not doing so can cause various problems, as hotunplugDisk could return a
Line 13: success result while it did not actually succeeds to detach the disk.
Line 14: 


https://gerrit.ovirt.org/#/c/45138/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2634: 
Line 2635:         hooks.before_disk_hotunplug(driveXml, self.conf,
Line 2636:                                     params=drive.custom)
Line 2637:         try:
Line 2638:             self._dom.detachDevice(driveXml)
> whatever route we take (polling/event),
Done
Line 2639:             opStarted = datetime.datetime.now()
Line 2640:             timoutSec = 10
Line 2641:             while drive.serial in self._dom.XMLDesc(0):
Line 2642:                 self.log.debug("Waiting for hotunplug to finish.")


-- 
To view, visit https://gerrit.ovirt.org/45138
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I393ce55dd761ac825cb96bd499976fd74c366b09
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list