Change in vdsm[master]: StorageDomainManifest: Move clusterLock into Manifest
nsoffer at redhat.com
nsoffer at redhat.com
Sun Aug 30 23:47:15 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: StorageDomainManifest: Move clusterLock into Manifest
......................................................................
Patch Set 11: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/43549/11/tests/sdm_indirection_tests.py
File tests/sdm_indirection_tests.py:
Line 306: ['inquire', 0],
Line 307: ])
Line 308: def test_clusterlock(self, op, nr_args):
Line 309: dom_method = op + 'ClusterLock'
Line 310: manifest_method = op + 'DomainLock'
Too smart, we don't want to save typing but save reader time.
Can be simpler like this:
@permutations([
# dom_method, manifest_method, nr_args
("acquireClusterLock", "acquireDomainLock", 1),
...
])
def test_clusterlock(self, dom_method, manifest_method, nr_args):
args = tuple(range(nr_args))
self._check(dom_method, args, [(manifest_method, args, {})])
Line 311: args = tuple(range(nr_args))
Line 312: self._check(dom_method, args, [(manifest_method, args, {})])
Line 313:
Line 314: @permutations([
--
To view, visit https://gerrit.ovirt.org/43549
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c019a7fed6ba793d2b3a2459af221b1abbff2a3
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list