Change in vdsm[master]: hsm: Support checkStatus param in getDeviceList

nsoffer at redhat.com nsoffer at redhat.com
Sun Aug 30 21:28:40 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: hsm: Support checkStatus param in getDeviceList
......................................................................


Patch Set 3:

(3 comments)

https://gerrit.ovirt.org/#/c/45093/3/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 1426: # @used:     The device is in use.
Line 1427: #            A device will be considered used on the following cases:
Line 1428: #            - a PV exists on this device and is part of a VG
Line 1429: #            - a partition table is found on the device
Line 1430: #            - The device is not accessible
> Pvcreate will fail as in the example below.
"Can't open /dev/mapper/36001405d37fe1b74e554233915d2c45e exclusively.  Mounted filesystem?" does not mean disk is not accessible. It means that the disk may have a mounted file system, so lets update the text to describe this situation.
Line 1431: #
Line 1432: # @unknown:  The device status is unknown
Line 1433: #            (new in version 4.17)
Line 1434: #


https://gerrit.ovirt.org/#/c/45093/3/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 2026
Line 2027
Line 2028
Line 2029
Line 2030
For example, we can add the status here:

    if not checkStatus:
        devInfo["status"] = "unknown"


Line 2023:                 pvsize = ""
Line 2024:                 vguuid = ""
Line 2025: 
Line 2026:             devInfo = {'GUID': dev.get("guid", ""), 'pvUUID': pvuuid,
Line 2027:                        'status': 'unknown',
> Since old engine will always have "checkstatus", 'unknown' will not be retu
Correct, but I wonder if we should make it more clear like by adding "status": "unknown" only if checkStatus is False.
Line 2028:                        'pvsize': str(pvsize),
Line 2029:                        'vgUUID': vguuid, 'vendorID': dev.get("vendor", ""),
Line 2030:                        'productID': dev.get("product", ""),
Line 2031:                        'fwrev': dev.get("fwrev", ""),


-- 
To view, visit https://gerrit.ovirt.org/45093
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic28954708f2fd7c7b721aa7f9a0fb6e1a6019597
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list