Change in vdsm[master]: netinfoTests: add a test for getNicsVlanAndBondingForNetwork

ibarkan at redhat.com ibarkan at redhat.com
Sun Aug 30 08:13:34 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: netinfoTests: add a test for getNicsVlanAndBondingForNetwork
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

kudos for picking up the gauntlet and touching this hideous piece of code.

https://gerrit.ovirt.org/#/c/45112/3/tests/netinfoTests.py
File tests/netinfoTests.py:

Line 345:                 'just-nic': {
Line 346:                     'bridged': False,
Line 347:                     'iface': 'eth0',
Line 348: 
Line 349:                     '_expected_nics': ['eth0'],
this should be a const variable in test_getNicsVlanAndBondingForNetwork. it is not part of getNicsVlanAndBondingForNetwork API, and a bit confusing.
Line 350:                     '_expected_vlan': None,
Line 351:                     '_expected_vlan_id': None,
Line 352:                     '_expected_bond': None,
Line 353:                 },


-- 
To view, visit https://gerrit.ovirt.org/45112
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie196879ef7fd8ea54816cd090dead569c04c7f5b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list