Change in vdsm[master]: Refactor v2v jobs for reusability

fromani at redhat.com fromani at redhat.com
Fri Aug 28 15:13:05 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: Refactor v2v jobs for reusability
......................................................................


Patch Set 9: Code-Review+1

(2 comments)

https://gerrit.ovirt.org/#/c/44857/9/vdsm/jobs.py
File vdsm/jobs.py:

Line 45:     name = None
Line 46: 
Line 47: 
Line 48: class JobExistsError(ClientError):
Line 49:     ''' Job already exists in _jobs collection '''
I'm not sure we should mention private implementation details in the public doc of the module, but this is not important enough to further delay this patch.
Line 50:     name = 'JobExistsError'
Line 51: 
Line 52: 
Line 53: class NoSuchJob(ClientError):


Line 50:     name = 'JobExistsError'
Line 51: 
Line 52: 
Line 53: class NoSuchJob(ClientError):
Line 54:     ''' Job does not exist in _jobs collection '''
same
Line 55:     name = 'NoSuchJob'
Line 56: 
Line 57: 
Line 58: class JobNotDone(ClientError):


-- 
To view, visit https://gerrit.ovirt.org/44857
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida6b1c460c5030c820c540e836e423d4632410df
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list