Change in vdsm[master]: virt: vm with port mirroring stuck in down state

mmirecki at redhat.com mmirecki at redhat.com
Wed Aug 26 13:10:40 UTC 2015


Marcin Mirecki has posted comments on this change.

Change subject: virt: vm with port mirroring  stuck in down state
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/45344/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3673:             for nic in self._devices[hwclass.NIC]:
Line 3674:                 if hasattr(nic, 'portMirroring'):
Line 3675:                     for network in nic.portMirroring:
Line 3676:                         supervdsm.getProxy().unsetPortMirroring(network,
Line 3677:                                                                 nic.name)
> question: when we unset port mirroring, shouldn't we update also the (vm? d
I assumed here that the _released flag will guard this.
If we want to do this at nic level, we could remove the 'portMirroring' attribute from the nic.
Line 3678: 
Line 3679:             self.log.info('Release VM resources')
Line 3680:             self.lastStatus = vmstatus.POWERING_DOWN
Line 3681:             # Terminate the VM's creation thread.


-- 
To view, visit https://gerrit.ovirt.org/45344
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia43369f584f696f1387685ec8f4fc4b6f58d98a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list