Change in vdsm[master]: Refactor v2v jobs for reusability

nsoffer at redhat.com nsoffer at redhat.com
Wed Aug 26 12:16:36 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: Refactor v2v jobs for reusability
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/44857/7/vdsm/v2v.py
File vdsm/v2v.py:

Line 282:         obj._run_command = obj._run
Line 283:         return obj
Line 284: 
Line 285:     def start(self):
Line 286:         t = threading.Thread(target=self._run_command)
> Do we really want to create new thread every time?
These requests are very slow, so the problem is not creating new thread, but not limiting the number of concurrent import operations.

Basically these are storage operations, and we have a limit of 10 concurrent tasks for storage. Basically these operation have to move to the same mechanism running storage tasks.

But this is not related to Adam patch, we will address this later.
Line 287:         t.daemon = True
Line 288:         t.start()
Line 289: 
Line 290:     @property


-- 
To view, visit https://gerrit.ovirt.org/44857
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida6b1c460c5030c820c540e836e423d4632410df
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list