Change in vdsm[master]: Revert "supervdsm: Decorator for supervdsm proxied calls."

danken at redhat.com danken at redhat.com
Wed Aug 26 11:09:35 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Revert "supervdsm: Decorator for supervdsm proxied calls."
......................................................................


Revert "supervdsm: Decorator for supervdsm proxied calls."

I've merged commit 9fad76d2075f315ebe48212508fe9b677d74dfc8
prematurely, before proper discussion about its merits and
disadvantages.

One disadvantage is the relative ease of decorating a
function and then, implicitly, having it run as root in all
contexts.

Change-Id: I1f83b4a8820f3fef437641329ba514742434dab4
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/45316
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
---
M lib/vdsm/supervdsm.py
M tests/functional/supervdsmFuncTests.py
M vdsm/supervdsmServer
3 files changed, 9 insertions(+), 76 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Dan Kenigsberg: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/45316
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1f83b4a8820f3fef437641329ba514742434dab4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list