Change in vdsm[master]: Limit sleep_millisecs to minimum 10
msivak at redhat.com
msivak at redhat.com
Wed Aug 26 08:59:50 UTC 2015
Martin Sivák has posted comments on this change.
Change subject: Limit sleep_millisecs to minimum 10
......................................................................
Patch Set 2:
(1 comment)
This looks like a good catch I just have one style comment.
https://gerrit.ovirt.org/#/c/45332/2/vdsm/mom.d/03-ksm.policy
File vdsm/mom.d/03-ksm.policy:
Line 105: (Host.Control "ksm_run" ksm_action)
Line 106: { # else
Line 107: (Host.Control "ksm_run" 1)
Line 108: (Host.Control "ksm_sleep_millisecs"
Line 109: (max 10(/ (* ksm_sleep_ms_baseline 16777216) Host.mem_available)))
Can you please split this into multiple lines or add a space? The expression is getting too long here.
Line 110: (if (< (Host.StatAvg "mem_free") ksm_pressure_threshold)
Line 111: (change_npages ksm_pages_boost)
Line 112: (change_npages ksm_pages_decay))
Line 113: }
--
To view, visit https://gerrit.ovirt.org/45332
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7412ca576089f1dae2441ec39f72e7a94b3c8fc9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list