Change in vdsm[master]: jsonrpc: executor based thread factory
nsoffer at redhat.com
nsoffer at redhat.com
Tue Aug 25 17:59:18 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
......................................................................
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/43759/7/vdsm/rpc/bindingjsonrpc.py
File vdsm/rpc/bindingjsonrpc.py:
Line 37: workers_count=_THREADS,
Line 38: max_tasks=_TASKS,
Line 39: scheduler=scheduler)
Line 40:
Line 41: self._server = JsonRpcServer(bridge, timeout, self._executor.dispatch)
> It will send it back to the client containing all the information provided.
Do we have a test for this? if not, maybe add it in this patch?
Line 42: self._reactor = StompReactor(subs)
Line 43: self.startReactor()
Line 44:
Line 45: def add_socket(self, reactor, client_socket):
--
To view, visit https://gerrit.ovirt.org/43759
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list