Change in vdsm[master]: vm: Libvirt quering after disk detach operation addition.

nsoffer at redhat.com nsoffer at redhat.com
Tue Aug 25 15:22:38 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: vm: Libvirt quering after disk detach operation addition.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/45138/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: vm: Libvirt quering after disk detach operation addition.
Line 8: 
Line 9: As stated in libvirt documentary, after detaching a device using the API
Line 10: we need to verify that this device has actually been detached.
> After talking to Eric Blake these are the conclusions:
If libvirt crash or restart, vdsm will panic and the operation will fail in the engine side. This is not a reason to use polling.

We should check how easy is to use the libvirt event. In any case, we should check the state of the vm when getting the event, or on timeout.
Line 11: 
Line 12: Not doing so can cause various problems, as hotunplugDisk could return a
Line 13: success result while it did not actually succeeds to detach the disk.
Line 14: 


-- 
To view, visit https://gerrit.ovirt.org/45138
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I393ce55dd761ac825cb96bd499976fd74c366b09
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list