Change in vdsm[master]: rpc.Bridge: sanitize optional, positional argument names

osvoboda at redhat.com osvoboda at redhat.com
Tue Aug 25 14:45:04 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: rpc.Bridge: sanitize optional, positional argument names
......................................................................


Patch Set 5:

I outlined my idea a little more in a comment to the reverting commit https://gerrit.ovirt.org/45266

I believe _Server._callMethod must accept a dictionary as a parameter (if any helper parameters are desired, which I doubt), or **kwargs, certainly not *args.

-- 
To view, visit https://gerrit.ovirt.org/45274
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic23ca1d06a394c73ae746e123209375ceb90243c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list