Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

danken at redhat.com danken at redhat.com
Tue Aug 25 13:54:00 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
......................................................................


Patch Set 7: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/42570/7/vdsm/virt/vmchannels.py
File vdsm/virt/vmchannels.py:

Line 60:                                event)
Line 61:                 # Try to forcibly remove this FD from EPOLL
Line 62:                 # To really stop receiving events
Line 63:                 try:
Line 64:                     self._epoll.unregister(fileno)
I don't think we understand the issue yet.

Please add logs for each "successful" branches ("else" and ENOENT) so we can at least have a bit more information if the linked bug ever reproduces.
Line 65:                 except IOError as e:
Line 66:                     # Ignore ENOENT
Line 67:                     if e.errno != errno.ENOENT:
Line 68:                         raise


-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer%redhat.com at gtempaccount.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list