Change in vdsm[master]: tool: Cleanup configurators imports

danken at redhat.com danken at redhat.com
Tue Aug 25 11:40:56 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: tool: Cleanup configurators imports
......................................................................


tool: Cleanup configurators imports

Make the import nicer:

- Replace unneeded multi-line imports with single line imports
  multi-line import should be done with (), not with fragile \
  but there was not real need for any of these imports.
- Unify absolute import syntax
  from .import foo -> from . import foo
- Unify whitespace around imports
- Import names in the same order (e.g. YES, NO, MAYBE)

Change-Id: Ie31ce1fbb0557784faf4a87a62c8abda1814701a
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/44859
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/tool/configurators/certificates.py
M lib/vdsm/tool/configurators/libvirt.py
M lib/vdsm/tool/configurators/multipath.py
M lib/vdsm/tool/configurators/passwd.py
M lib/vdsm/tool/configurators/sanlock.py
M lib/vdsm/tool/configurators/sebool.py
M tests/toolTests.py
7 files changed, 12 insertions(+), 45 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/44859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie31ce1fbb0557784faf4a87a62c8abda1814701a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list