Change in vdsm[master]: vm: make acpiShutdown more robust

danken at redhat.com danken at redhat.com
Tue Aug 25 10:20:54 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: vm: make acpiShutdown more robust
......................................................................


Patch Set 8:

(4 comments)

nits

https://gerrit.ovirt.org/#/c/34879/8//COMMIT_MSG
Commit Message:

Line 12: want
may want


Line 15: None
disconnected


Line 19: address
addresses


https://gerrit.ovirt.org/#/c/34879/8/tests/vmfakelib.py
File tests/vmfakelib.py:

Line 260: recorded
not used here, please drop.


-- 
To view, visit https://gerrit.ovirt.org/34879
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I244f00d62ee24fb42ba3d654961a8fc22f4a6c25
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list