Change in vdsm[master]: Refactor v2v jobs for reusability

nsoffer at redhat.com nsoffer at redhat.com
Mon Aug 24 21:38:03 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: Refactor v2v jobs for reusability
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/44857/3/vdsm/v2v.py
File vdsm/v2v.py:

Line 45: import caps
Line 46: import jobs
Line 47: 
Line 48: 
Line 49: _V2V_JOB_TYPE = 'v2v'
> I disagree.  It is used in two places: 1) when actually defining the type i
Ok
Line 50: _V2V_DIR = os.path.join(P_VDSM_RUN, 'v2v')
Line 51: _VIRT_V2V = CommandPath('virt-v2v', '/usr/bin/virt-v2v')
Line 52: _OVF_RESOURCE_CPU = 3
Line 53: _OVF_RESOURCE_MEMORY = 4


-- 
To view, visit https://gerrit.ovirt.org/44857
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida6b1c460c5030c820c540e836e423d4632410df
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list