Change in vdsm[master]: net: iproute2, pyroute2: implement rollback

danken at redhat.com danken at redhat.com
Mon Aug 24 15:14:45 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: net: iproute2, pyroute2: implement rollback
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/45238/2/vdsm/network/configurators/iproute2.py
File vdsm/network/configurators/iproute2.py:

Line 95: supervdsm.getProxy().
this already runs in supervdsm context. How about returning the proper "leftover"?

API.py line 1634 should handle it.


-- 
To view, visit https://gerrit.ovirt.org/45238
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ba8cd7bb1356063abc0df24e65810dbb9235dcd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list