Change in vdsm[master]: gluster: fix AttributeError in exception.py

danken at redhat.com danken at redhat.com
Sun Aug 23 18:38:26 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: gluster: fix AttributeError in exception.py
......................................................................


gluster: fix AttributeError in exception.py

Currently whenever an exception raised with extra arguments
apart from rc, out, err; the exception failed with
AttributeError due to base class member variables are not
initialized properly.

This patch fixes this AttributeError issue by calling the
ancestor's __init__ method explicitly to invoke base class
constructor which will initialize the base class member
variables like rc, out and err.

Change-Id: Ic4c72daf30aee8f0024b1ef9ee064a205a500620
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1231722
Signed-off-by: Timothy Asir Jeyasingh <tjeyasin at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/41530
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Ramesh N <rnachimu at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Continuous-Integration: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/gluster/exception.py
1 file changed, 17 insertions(+), 9 deletions(-)

Approvals:
  Timothy Asir: Verified
  Dan Kenigsberg: Looks good to me, approved; Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve
  Ramesh N: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/41530
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4c72daf30aee8f0024b1ef9ee064a205a500620
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: rebecca salomi <rebekkalsalomi at gmail.com>


More information about the vdsm-patches mailing list