Change in vdsm[master]: storage: validate vdsm rwx permissions for file storage

danken at redhat.com danken at redhat.com
Sun Aug 23 10:17:42 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: storage: validate vdsm rwx permissions for file storage
......................................................................


storage: validate vdsm rwx permissions for file storage

VDSM needs permission to write to file-based storage.  Presumably the
existing check for qemu permissions or a subsequent failure would throw
an error; however, these errors were not always clear nor did they help
the user (e.g. a general Error 100, such as in the referenced bug).

With an explicit check, we can ensure the failure happens up-front and
gives a meaningful error message to the user.

Change-Id: I8276c36042bef57c80c8920041b1f3446cdfc372
Bug-Url: https://bugzilla.redhat.com/1250752
Signed-off-by: Greg Padgett <gpadgett at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/44442
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
---
M vdsm/storage/fileSD.py
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Greg Padgett: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/44442
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8276c36042bef57c80c8920041b1f3446cdfc372
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list