Change in vdsm[master]: Refactor v2v jobs for reusability
nsoffer at redhat.com
nsoffer at redhat.com
Sat Aug 22 00:00:43 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/44857/3/vdsm/jobs.py
File vdsm/jobs.py:
Line 73: _JOB_TYPE = None
Line 74:
Line 75: def __init__(self, job_id, description=''):
Line 76: self._id = job_id
Line 77: self._status = STATUS.RUNNING
> Perhaps I should just add starting as a v2v-specific status and keep runnin
Seems safer and will allow quicker merge, as we did not get any reply on this from v2v guys yet.
Line 78: self._description = description
Line 79:
Line 80: @property
Line 81: def id(self):
--
To view, visit https://gerrit.ovirt.org/44857
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida6b1c460c5030c820c540e836e423d4632410df
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list