Change in vdsm[master]: hsm: prepareForShutdown - operations order

nsoffer at redhat.com nsoffer at redhat.com
Thu Aug 20 15:14:08 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: hsm: prepareForShutdown - operations order
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/36162/4/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 3452:                 self.log.warning("Failed to stop RepoStats thread",
Line 3453:                                  exc_info=True)
Line 3454: 
Line 3455:             self.taskMng.prepareForShutdown()
Line 3456:             sp.StoragePool.cleanupMasterMount()
> So what do you suggest? the current situation is problematic as well...it's
The easy fix would be to remove the code that always fail in the current way we shut down, since this code was never correct.

The long term fix is to redesign the system so we can stop/cleanup concurretnly, and only then wait for all threads.
Line 3457:         except:
Line 3458:             pass
Line 3459: 
Line 3460:     @classmethod


-- 
To view, visit https://gerrit.ovirt.org/36162
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9edd84317b08a17db80e265053edaf69582c2a51
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list