Change in vdsm[master]: vm.py: State saving in hotunplugDisk.

fromani at redhat.com fromani at redhat.com
Thu Aug 20 13:21:10 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vm.py: State saving in hotunplugDisk.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/45077/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2648:         else:
Line 2649:             hooks.after_disk_hotunplug(driveXml, self.conf,
Line 2650:                                        params=drive.custom)
Line 2651:             self._cleanupDrives(drive)
Line 2652:             self.saveState()
> I think this should work like this:
Good catch, I overlooked the crash after detach issue. My fault. It is partially because the real issue being addressed here is that we want to update xml description and devices hash, which is done by update domain descriptor, which in turn is buried deep saveState.

We should deentangle the two actions here, which involves a fair amount of refactoring if we want to avoid useless duplicated work (explicit update _and_ implicit update inside saveState)

BTW, the best solution with respect the saveState handling is what Nir described.
Line 2653: 
Line 2654:         return {'status': doneCode, 'vmList': self.status()}
Line 2655: 
Line 2656:     def _readPauseCode(self):


-- 
To view, visit https://gerrit.ovirt.org/45077
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2cf18186cbba33d7e74fd15651ffec3149c98e1d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list