Change in vdsm[master]: Refactor v2v jobs for reusability

nsoffer at redhat.com nsoffer at redhat.com
Thu Aug 20 11:24:55 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: Refactor v2v jobs for reusability
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/44857/3/vdsm/v2v.py
File vdsm/v2v.py:

Line 107: 
Line 108: def get_jobs_status():
Line 109:     all_jobs = jobs.get_jobs_status()
Line 110:     return {job_id: status for (job_id, status) in all_jobs.items()
Line 111:             if status['job_type'] == _V2V_JOB_TYPE}
> I was missreading this. But this filtering is better done in the jobs modul
get_job_status should have a job_type argument to allow filtering.
Line 112: 
Line 113: 
Line 114: def get_external_vms(uri, username, password):
Line 115:     if not supported():


-- 
To view, visit https://gerrit.ovirt.org/44857
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida6b1c460c5030c820c540e836e423d4632410df
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list